Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make sure to uniformly 0x-prefix hex strings in custom error message #688

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Sep 30, 2024

Fixes NomicFoundation/hardhat#5793

The address case slipped through the cracks - I adapted the stack trace test and added a unit test for that.

cc @fvictorio

@Xanewok Xanewok requested review from fvictorio and a team September 30, 2024 11:46
Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: ac749eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/edr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Xanewok Xanewok had a problem deploying to github-action-benchmark September 30, 2024 11:46 — with GitHub Actions Error
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@Xanewok Xanewok added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit a1cee4f Sep 30, 2024
37 checks passed
@Xanewok Xanewok deleted the fix/custom-errors-0x-prefix branch September 30, 2024 12:15
@Xanewok Xanewok added this to the Solidity tracing port milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return value is 0x double-padded in custom errors.
2 participants